Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a complete language tag processing solution including a library with support for ISO 639‑2, ISO 639‑3, and RFC 5646 language tags, a code generation utility, and test fixtures. It also adds supplementary projects and CI/CD workflow configurations to automate build, format, and release tasks.
- Added test fixture for language data file resolution.
- Implemented language tag parsing, code generation, and lookup methods.
- Configured project files, build tasks, and GitHub workflows for data updates, releases, and merge automation.
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| LanguageTagsTests/Fixture.cs | New test fixture with a relative data file path helper. |
| LanguageTagsTests/.editorconfig | Editor configuration for test projects. |
| LanguageTagsCreate/Program.cs | Main utility for downloading language data and code generation. |
| LanguageTagsCreate/LanguageTagsCreate.csproj | Project file for the code generation utility. |
| LanguageTags/Rfc5646.cs | Library implementation with parsing, JSON conversion, and code generation. |
| LanguageTags/LanguageTags.csproj | Project file for the main library. |
| LanguageTags/LanguageLookup.cs | Implementation for language tag lookup and conversion. |
| LanguageTags/JsonOptions.cs | JSON serializer options configuration. |
| LanguageTags/Iso6393.cs | ISO 639‑3 data parsing and code generation implementation. |
| LanguageTags/Iso6392.cs | ISO 639‑2 data parsing and code generation implementation. |
| LanguageTags.sln | Solution file including all projects and configuration. |
| LanguageTags.code-workspace | Workspace configuration for coding standards. |
| .vscode/tasks.json | Build and format task definitions. |
| .vscode/launch.json | Debug launch configuration for LanguageTagsCreate. |
| .github/workflows/update-languagedata.yml | Workflow to update language data and generate code. |
| .github/workflows/publish-release.yml | CI workflow for building, testing, and publishing releases. |
| .github/workflows/merge-bot-pr.yml | Workflow to auto‑merge bot generated PRs. |
| .github/dependabot.yml | Dependabot configuration for NuGet and GitHub Actions. |
| .gitattributes | Attributes configuration for consistent line endings. |
| .editorconfig | Root editorconfig enforcing coding styles and formatting. |
Comments suppressed due to low confidence (1)
LanguageTags/Rfc5646.cs:240
- Instead of throwing a NotImplementedException for unknown attribute keys, consider logging the unexpected attribute or handling it gracefully to improve robustness in production.
default: throw new NotImplementedException();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.